Remove useless type cast on aggregated value #39063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Apr 27, 2020
This is required for rails#39063 to use `PG::TextDecoder::Numeric`. Ref ged/ruby-pg#25. The pg gem 1.1.0 was released at August 24, 2018, so I think it is good timing to bump the required version for improving and cleaning up the code base. https://rubygems.org/gems/pg/versions
Related rails#39039. Currently PostgreSQL adapter is the only adapter that rely on type casting by `result.column_types`, now the adapter can return numeric value without type casting by Active Record side. So we can remove that useless type cast on aggregated value.
kamipo
force-pushed
the
remove_useless_typecast_on_aggregation
branch
from
847b395
to
e10765c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #39039.
Currently PostgreSQL adapter is the only adapter that rely on type
casting by
result.column_types, now the adapter can return numericvalue without type casting by Active Record side.
So we can remove that useless type cast on aggregated value.